ref(analytics): Transform analytics events for TET-825 #95205
Conversation
- Transform event classes to use @analytics.eventclass decorator - Transform analytics.record calls to use event class instances - Update imports as needed Closes TET-825
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95205 +/- ##
==========================================
+ Coverage 86.52% 87.84% +1.31%
==========================================
Files 10478 10478
Lines 605960 605802 -158
Branches 23674 23641 -33
==========================================
+ Hits 524303 532156 +7853
+ Misses 81293 73286 -8007
+ Partials 364 360 -4 |
Not sure why the same logic returns a different result now that is not in a hook anymore. However, the color ended up being white after moving this to the theme and this PR fixes it.
Move the `OnboardingStep` type out of the `Step` component file as the type is also used in other components and a general building block of our docs structure. Move `TabbedCodeSnippet` from `step.tsx` into `onboardingCodeSnippet.tsx` since it is just a utility wrapper for it and also is used in a multitude of places that do not use the `Step` component. - closes [TET-841: Move general onboarding doc types out of step component file](https://linear.app/getsentry/issue/TET-841/move-general-onboarding-doc-types-out-of-step-component-file)
The arcade for the profiling onboarding got blocked by our CSP. This PR streamlines the embed URL to use the same format as the other arcades.
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| project_id: str | ||
| event_id: str |
| actor_id: str | None = None | ||
| id: str |
There was a problem hiding this comment.
Same as above - are these ints or str?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…low for easier testing" This reverts commit baf5a77.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Bug: Type Mismatch: Project ID Should Be Integer
The project_id field in GroupingParameterizationExperiment is typed as str but should be int. Sentry project IDs are consistently integers, aligning with other analytics events (e.g., EventUserSnubaQuery uses list[int] for project IDs). The event_id field is correctly typed as str. This project_id type mismatch will cause type checking errors and could lead to runtime issues or incorrect data recording.
src/sentry/analytics/events/grouping_parameterization_experiment.py#L6-L8
Was this report helpful? Give feedback by reacting with 👍 or 👎
Closes TET-825